Am Sonntag, den 11.07.2010, 14:11 -0400 schrieb Daniel Lenski:
> On Sun, Jul 11, 2010 at 6:58 AM, Daniel Lenski <[email protected]> wrote:
> > I am attaching a patch, as well as the output of flashrom -VE, -Vr, and -Vw
> > run on this chip with the patch in place.  I'm programming it via the AMD
> > SB7x0 interface.
> 
> My patch should have indicated the tested, working status of this
> chip.  Sorry, here's a fixed one.

Your patch looks mostly fine. Please add a sign-off according to
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

Also, please use tabs instead of spaces before the comment in flashchips.h.

Except for the tab issue, the patch is
Acked-by: Michael Karcher <[email protected]>

Regards, and thanks for the patch,
  Michael Karcher


_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to