hey urja! coding style: the tabs are certainly to be used according to the official coreboot rules, but the rest is just my personal view. i am not sure how the other devs think about it.
opbuf/delay: what's the use of this in spi mode? i dont see why this is needed at all. patch split: dunno. it might be overlooked if the rest is not committed. therefore i explicitly mentioned this in case someone with commit rights reads the review ;) -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
