I've pushed the changes to my fork, waiting for your comments. On Thu, Jan 20, 2011 at 13:31, Roberto Lo Giacco <[email protected]>wrote:
> Ok, I'll give a look on how much it need to be changed to fix our needs.... > I'll be back to you soon on this > > > On Thu, Jan 20, 2011 at 12:29, Marvin Froeder <[email protected]> wrote: > >> Well, have 2 goal with similar logic means one will evolve and the other >> will be forgotten =/ >> >> Also, CopyMojo also has logic to deal with modules, runtime localization >> and rsls.... this DependencyProcessorMojo only covers RSLs.... >> >> VELO >> >> >> On Thu, Jan 20, 2011 at 9:02 AM, Roberto Lo Giacco >> <[email protected]>wrote: >> >>> If you prefer I can patch that goal, but I think a different goal better >>> fit our needs. The CopyMojo works perfectly for war files and I love it, >>> patching it can lead to a lot os switches in the code bacause of different >>> default output directories, different artifact ype, etc... And I didn't want >>> to break anything in the existing code so no complains will raise on the new >>> version as many people is still using that version. >>> >>> I just wished to be on the safe side and I thought adding a different >>> mojo could be the safest solution... But I see your point and I can refactor >>> the CopyMojo if you wish.... still I think it's not the safest solution. >>> >>> Cheers >>> >>> >>> On Thu, Jan 20, 2011 at 10:51, Marvin Froeder <[email protected]> wrote: >>> >>>> I don't see the point on creating a second goal that does almost the >>>> same thing.... it would make more sense patch the goal that already exists >>>> then.... >>>> >>>> >>>> On Thu, Jan 20, 2011 at 7:27 AM, Roberto Lo Giacco <[email protected] >>>> > wrote: >>>> >>>>> Yes, it partially overlap but the CopyMojo works on war artifacts only >>>>> while we wish to copy dependent artifacts into SWF project as well for >>>>> testing purposes: our flex project is modular and we want to test it out >>>>> of >>>>> the scope of a war file... >>>>> >>>>> The alternative was to process the dependencies, including transitive >>>>> ones, and copy all the artifacts using the dependency plugin, but as we >>>>> use >>>>> non-standard scopes (rsl, caching) which change the artifact type `on the >>>>> fly` it was not applicable. >>>>> >>>>> Do you see my point or should I further explain? >>>>> >>>>> On Wed, Jan 19, 2011 at 23:37, Marvin Froeder <[email protected]>wrote: >>>>> >>>>>> What is this DependencyProcessorMojo for? Doesn't it overlay CopyMojo? >>>>>> >>>>>> VELO >>>>>> >>>>>> >>>>>> On Wed, Jan 19, 2011 at 6:33 PM, Roberto Lo Giacco < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Pull request made, but I think I've to process the additional `cache` >>>>>>> scope into the DependencyProcessorMojo... but I'm not sure... >>>>>>> >>>>>>> On Wed, Jan 19, 2011 at 13:44, Marvin Froeder <[email protected]>wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Jan 19, 2011 at 11:41 AM, Roberto Lo Giacco < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Pushing to my fork right now. >>>>>>>>> >>>>>>>> >>>>>>>> Ok, make pull requests to my fork and I will take a look ASAP. >>>>>>>> >>>>>>>> VELO >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "Flex Mojos" group. >>>>>>>> To post to this group, send email to [email protected] >>>>>>>> To unsubscribe from this group, send email to >>>>>>>> [email protected]<flex-mojos%[email protected]> >>>>>>>> For more options, visit this group at >>>>>>>> http://groups.google.com/group/flex-mojos >>>>>>>> >>>>>>>> http://flexmojos.sonatype.org/ >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Flex Mojos" group. >>>>>>> To post to this group, send email to [email protected] >>>>>>> To unsubscribe from this group, send email to >>>>>>> [email protected]<flex-mojos%[email protected]> >>>>>>> For more options, visit this group at >>>>>>> http://groups.google.com/group/flex-mojos >>>>>>> >>>>>>> http://flexmojos.sonatype.org/ >>>>>>> >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Flex Mojos" group. >>>>>> To post to this group, send email to [email protected] >>>>>> To unsubscribe from this group, send email to >>>>>> [email protected]<flex-mojos%[email protected]> >>>>>> For more options, visit this group at >>>>>> http://groups.google.com/group/flex-mojos >>>>>> >>>>>> http://flexmojos.sonatype.org/ >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Flex Mojos" group. >>>>> To post to this group, send email to [email protected] >>>>> To unsubscribe from this group, send email to >>>>> [email protected]<flex-mojos%[email protected]> >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/flex-mojos >>>>> >>>>> http://flexmojos.sonatype.org/ >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Flex Mojos" group. >>>> To post to this group, send email to [email protected] >>>> To unsubscribe from this group, send email to >>>> [email protected]<flex-mojos%[email protected]> >>>> For more options, visit this group at >>>> http://groups.google.com/group/flex-mojos >>>> >>>> http://flexmojos.sonatype.org/ >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Flex Mojos" group. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected]<flex-mojos%[email protected]> >>> For more options, visit this group at >>> http://groups.google.com/group/flex-mojos >>> >>> http://flexmojos.sonatype.org/ >>> >> >> -- >> You received this message because you are subscribed to the Google >> Groups "Flex Mojos" group. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected]<flex-mojos%[email protected]> >> For more options, visit this group at >> http://groups.google.com/group/flex-mojos >> >> http://flexmojos.sonatype.org/ >> > > -- You received this message because you are subscribed to the Google Groups "Flex Mojos" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/flex-mojos http://flexmojos.sonatype.org/
