On Sun, Nov 9, 2008 at 9:44 AM, Martin Spott wrote:
> Martin Spott wrote:
>
> > for a rather long time now I have always been applying this patch to my
> > SimGear builds:
> >
> > http://blaniel.free.fr/pub/flightgear/patches/ot_simgear.patch
> >
> > I have to admit that I never made any performance comparison against
> > the previous state, nevertheless I have the impression that applying
> > this patch adds to a proper 'cleanup' of the current source code.
>
> Does anyone of FlightGear's CVS commit people have an opinion about
> this patch ?
My opinion which I've stated before is that I'm extremely nervous about
anyone messing with the thread structure of FlightGear because this can lead
to bugs that are extremely subtle and extremely hard to find and reproduce.
So in my opinion we need to have at least one other developer, who is very
familiar with threading concepts, make a *very* careful review of these
patches and do some very thorough tests, and if they are confident in the
results, then I'd be worth adding.
Taking a very quick look at the patch, I see at least two changes that
aren't a direct 1-to-1 switch from our simgear pthread wrapper class, to osg
thead wrappers. I'd really like to understand more about the purpose of
those additions.
Regards,
Curt.
--
Curtis Olson: http://baron.flightgear.org/~curt/
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Flightgear-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
