* Stuart Buchanan -- Tuesday 03 February 2009:
> I was looking at the <mask> tag for the property-adjust, which I
> noticed wasn't previously used in the kx165. However, when I tried
> it I found two problems. [...]
> 1) The <mask>decimal</mask> affected high-order integer values as well
That should be fixable.
> 2) A roundoff problem with the texttranslate animation caused a
> display problem.
I don't understand this argument: Both property-adjust and airraft.tuner
change a frequency number. How would one work with (a broken?) textranslate
and the other not?
> I like the Nasal solution, and I think we should offer it for
> Aircraft developers to use if they wish, possibly by including
> it in aircraft.nas or controls.nas, but I would also like to
> fix the property-adjust bugs so the Nasal version doesn't end
> up as a workaround.
I vote for fixing property-adjust and not committing the class.
Adjusting a frequency is almost always done in bindings, and
property-adjust is way faster than the nasal class. And it's
also callable from nasal if necessary:
fgcommand("property-adjust", props.Node.new({}));
So having the same again in a different form doesn't buy us much.
We have already a lot of Nasal code, and we'll be adding more.
aircraft.nas is already a big file -- I wouldn't like to see
redundant code added there, just so people can choose between
two equivalent ways.
m.
BTW: even Torsten's revised version is problematic. For example,
why is delta only checked in the middle of the function and if
it's zero it carries on as noop? What does "ext" mean? External?
Extra? Extension? etc. :-)
m.
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
