On 09/09/2009 07:06 PM, John Denker wrote: > On 09/09/09 06:16, Tim Moore wrote: > >>>> Yes, the 2009 code is different from the 2007 code. >>>> The 2009 features and bugfixes are a superset of the >>>> 2007 features and bugfixes. Also the 2009 commits >>>> were rebased so that they applied cleanly to the FGFS >>>> release that was current at the time. >>>> >>> That's great! What's the url for the repository that has these changes? >>> Unless I'm doing something wrong, it seems like >>> http://www.av8n.com/repo/fgs/.git >>> and http://www.av8n.com/repo/sg/.git haven't been updated in some >>> time. > > I updated that site just now. I had stopped using > it more than two years ago, because it is just a > fileserver (lots of network connectivity, without > much CPU capacity) ... meaning it didn't support > gitweb. I thought it would be more convenient > for folks to evaluate my patches if I put my FGFS > stuff on a gitweb-enabled host. It turned out it > didn't make much difference. I find gitweb a poor substitute for cloning the repository and using gitk and the command line tools to poke around. But why don't you put your repositories on a well-known git hosting site that supports gitweb and more? Most convenient would be to fork my repositories on repo.or.cz and base your sportmodel on those. James Turner looked > at a couple of my patches using gitweb, but the > only folks who actually downloaded and tested the > patches were folks without commit authority. My > FGFS gitweb host died a while back. I didn't > bother to replace it, since it wasn't seeing any > traffic. ...
> On 09/09/09 07:08, James Turner wrote: ... >> simply >> that either I need to be able to convince myself that a specific >> change is correct .... Otherwise, I'll leave any >> functional changes to to others. > > What others? As of January, I was under the impression > that you, James, were the one and only maintainer of > navradio.cxx. Are you suggesting that there is someone He is now :) > with commit authority who was interested and/or > qualified to judge the correctness of my code? I > was quite unaware of this back in January. Has the > situation changed somehow? > > Several people did try out my code ... just nobody with > commit authority. Evidently this kind of testing doesn't > count. > > Is the criterion that I have to prove that my patches > are absolutely correct? I don't see how it would ever > be possible to do that. The code had tons of bugs > before I touched it, and it has tons of bugs now. It > seems safe to say that accepting my patches would have > resulted in a better feature set and _far fewer_ bugs, > to say the least. No one wants a formal proof, but some comments might be in order. For whatever reason your patches tend to be controversial. Anyway, I committed your changes to simgear. I'm sorry that the author info got lost in the CVS commit; I'll use the -a flag on git cvsexportcommit in the future. When I look at your sportmodel branch with my software engineer hat on (no pilot helmet here), I see features that would be great to have, but also a lot of code that we already know won't merge cleanly. So, I propose to pick apart sportmodel as much as possible into patch series that don't depend on each other. There are a lot of changes to navradio.[ch]xx, but you and James are in heated discussion, so I'm not touching that. Instead, it looks like "Two-parameter physics-based model of atmosphere up to 262,467 ft i.e. the top of the mesosphere. Correctly exhibits the HALT phenomenon." would be awesome to have and is relatively independent of the rest of sportmodel. So, I have split out just that changeset and merged it to my next branch (basically CVS HEAD). I've pushed the result to the jsd/environment branch in git://repo.or.cz/flightgear.git. Could you take a look and see if this merge is correct, especially with respect to the live_update stuff that was introduced since you made your changes? Before this is checked in to CVS I'd like to see if Unpack.hxx can be replaced with Boost tuples, but otherwise the code looks good. Thanks, Tim ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
