On Tue, Feb 23, 2010 at 11:36 PM, John Denker <j...@av8n.com> wrote:
> On 02/15/2010 03:19 AM, Tim Moore in part wrote:
>
> > readline() is pretty gross;
>
> The best way to remove the grossness is to extirpate
> readline and replace it with something that has a
> nicer interface ... such as returning a std::string.
>
> I wrote a getline function to do this. Much cleaner.
> No need for 16kbyte buffers all over the place. (*)
>
> The patch can be found in the usual place:
>
> http://gitorious.org/~jsd/fg/sport-simgear/commits/sport<http://gitorious.org/%7Ejsd/fg/sport-simgear/commits/sport>
>
> An aside, it's easier for me to find a commit that has a commit ID. In this
case I guessed what file your getline is in and used git log to find the
patch, but in general I don't want to grovel through logs.
> Over on the FG side, this requires some minor upgrades:
>
> http://gitorious.org/~jsd/fg/sport-model/commits/sport<http://gitorious.org/%7Ejsd/fg/sport-model/commits/sport>
>
> I tried asking for suggestions and/or review off-list,
> but it appears that mail to timoor...@gmail.com never
> goes through. Is it a list-mail address only?
>
> In an ideal world you would receive more feedback from a list than an
individual. But anyway...
getline looks fine. Instead of getting steamed about readline, why not
implement it in terms of getline?
Tim
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
