On 04/14/2013 06:13 PM, Diogo Kastrup wrote: > A long time ago I started working on a different implementation for > YASim static friction. With help from Csaba and Mathias Fröhlich the > patch worked but I never finished polishing it to submit a final > version.
Vivian poked me about this one, so I got here in time for a change. :) Can I be a jerk and kick this back for patch formatting reasons? I think I get the idea here: it's detecting the "stopped" condition and replacing the existing friction mechanism with a spring model around a fixed point. And that makes sense to me. But it's really hard to review: there's no commit message explaining what's happening; lots and lots of the modifications are just whitespace changes to existing code that I have to prune out to read the real changes; some things just don't make sense, like the apparent addition of tmul33() and family to Math.hpp which I swear was there before... Would it be too much to ask for Diogo (or anyone else) to do a cleanup pass on this? Andy ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
