Fabien Costantini wrote: >>> Log: >>> Reverted las Makefile changes. This is not acceptable because any >>> modification tyo xutf8 file must be achieved in corresponding xutf >>> Makefile. So Instead of cleaning the file generated by xutf Makefile by src >>> makefile, you have to do that in the xutf8 Makefile instead. >> You're wrong: > No I am not, but you probably meant you 'think' I'm wrong.
I still think so ... >> (1) These object files are created with src/Makefile, they must be >> deleted with src/Makefile as well. >> (2) src/xutf8/Makefile is not involved in the build process, maybe it >> should be deleted. > Again, no, at least not always, compile under mingw and see that this > makefile is indeed used (otherwise I would not have bothered to fix it in > 6461. That's no proof that you are right. Maybe you ran make in the src/xutf8 dir. ? I still want to understand how it would be used. After svn update and svn export (to get rid of the .svn dirs) I did this: find . -type f | xargs grep -iH xutf8 | sed -e 's/:.*//g' | sort -u ./documentation/TODO.doc ./FL/fl_utf8.h ./FL/x.H ./FL/Xutf8.h ./ide/vc2005/fltkdll.vcproj ./ide/vc2005/fltk.lib.vcproj ./ide/visualc/fltkdll.dsp ./ide/visualc/fltk.lib.dsp ./ide/Xcode3.1/FLTK.xcodeproj/project.pbxproj ./src/Fl_Font.H ./src/fl_font_x.cxx ./src/fl_font_xft.cxx ./src/fl_utf8.cxx ./src/Fl_x.cxx ./src/gl_draw.cxx ./src/Makefile ./src/xutf8/case.c ./src/xutf8/is_right2left.c ./src/xutf8/is_spacing.c ./src/xutf8/keysym2Ucs.c ./src/xutf8/makedepend.bak ./src/xutf8/Makefile ./src/xutf8/Makefile.bak ./src/xutf8/README ./src/xutf8/test2.c ./src/xutf8/test.c ./src/xutf8/utf8Input.c ./src/xutf8/utf8Utils.c ./src/xutf8/utf8Wrap.c ./src/xutf8/utils/case.sh ./src/xutf8/utils/INSTALL ./src/xutf8/utils/non_spacing.sh ./TODO.utf8 Now, would you please explain, what magic in these files makes the fltk build use the file src/xutf8/Makefile under mingw? I don't use mingw, thus may I ask: Can anybody else confirm that this Makefile is really used to build (or install) fltk with mingw? What happens if you delete it, run make distclean (and delete src/xutf8/*.o manually), and run make after this? > Now if these files are compiled in src in some platforms, In all but mingw ? > we probably have to change that and fix it for it to compile at the good > place, this would certainly be the correct approach. Maybe. But I didn't want to do that, since it is still work in progress, and some cleanup would have to be done, anyways. I only wanted to fix the STR. Obviously Matthias decided to add these files to src/Makefile with .o files in src/xutf8, but if that was intended or not and should be changed, is not subject of the STR. Feel free to do it if you want (or add another STR), but maybe the better way would be to move the needed files to the src directory at some time later, when the utf8 work is finished. > In all cases the proposed fix is not satisfactory as is. I'm still not convinced ... Albrecht _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
