On 11/05/12 11:05, Matthias Melcher wrote:
> 
> On 16.10.2012, at 10:42, "MacArthur, Ian (SELEX GALILEO, UK)" 
> <[email protected]> wrote:
> 
>>
>>> Reawakening this thread.
>>>
>>> +1 for 1.3.1 release, with the ABI breaking stuff turned off by default,
>>> and calling it 1.3.1 (not .2)
>>
>>
>> Yes. I probably voted before (!) but I'm +1 on just pushing out what we 
>> have...
> 
> 
> OK, I will have a little bit of time for a release. What needs to be turned 
> off?

        Albrecht brought this up, and want him to check what I write here,
        but I think what this is about is a few things; before releasing 1.3.1,
        we need to change this line in Enumerations.H:

#define FLTK_ABI_VERSION 10302

        ..to either be commented out, or set to:

#define FLTK_ABI_VERSION 10300

        ..so that all ABI breaking features are off by default, so that
        a default build will be binary compatible with 1.3.0 release
        (ie. DLL compatibility).

        The reason it's set to 10302 now is so that svn devs can be testing
        the new ABI breaking features, but we don't want those to be
        enabled during "patch" releases (e.g. 1.3.0 -> 1.3.1),
        only "minor" releases (e.g. 1.3 -> 1.4).

        So after 1.3.1 goes out, we'd switch FLTK_ABI_VERSION back to 10302
        so that all new ABI breaking features added will be 1.3.2 features.

        Not sure, but I think we may /also/ need to change all instances
        of tests for FLTK_ABI_VERSION that  currently refer to "10302"
        and change them instead to 10301, eg:

BEFORE: #if FLTK_ABI_VERSION >= 10302
 AFTER: #if FLTK_ABI_VERSION >= 10301

BEFORE: #if FLTK_ABI_VERSION < 10302
 AFTER: #if FLTK_ABI_VERSION < 10301

        I /think/ 10302 was used is because 1.3.1 was slated to be a 
micro-release
        to fix a very specific problem in 1.3.0, and so 1.3.2 was going to be a
        regular multiple features/fixes release. But since that 1.3.1 micro 
release
        never happened, 1.3.1 is going to be a regular patch release.

        So we should change the ABI macros from 10302 -> 10301 to reflect that
        the ABI breaking features implemented so far are 1.3.1 compatible (and
        off by default)

        FWIW, the CMP docs on FLTK_ABI_VERSION:
        http://fltk.org/cmp.php#FLTK_ABI_VERSION

        Albrecht, does that all sound right?
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to