On 24 Mar 2013, at 17:59, David FLEURY wrote: > Hi, > I am using fluid under win32, and I miss an icon for this application. > I have done this patch to add an icon (only vs2010) > May be there are others win32 users of fluid > Regards, > David
This is a worthy idea, but I have some concerns about this version of the patch: - I know it is "normal" for MS stuff to call the resource file just "resource.h", but it seems suspect to me; we should call it something that makes it clearer what it is, even "fluid_resource.h" would be better, IMHO. Also, there's cruft in there we do not need for the simple case of adding an icon, anyway. - fluid.rc needs cleaned up, there's a lot of (auto-generated?) extraneous cruft in there that we don't need to just add an icon resource to a exe. Actually, I'm not certain what's there will even work for any user who does NOT have a French domain set on their build machine... - I can't comment on the patch to fluid.vcxproj; it is probably correct, but since I only ever use the mingw tools for WinXX nowadays, I can't tell! - If we are going to do this, then the provided icon in the fluid/icons/fluid.ico folder needs to be improved; it does not have enough of the bigger sizes for the modern systems, so looks a bit duff most of the time. _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
