[
https://issues.apache.org/jira/browse/FLUME-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188810#comment-13188810
]
[email protected] commented on FLUME-889:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3524/#review4456
-----------------------------------------------------------
In my opinion its better not re-size when the new size is smaller that number
of events in the queue. The warning in log will can indicate that the queue was
not re-sized.
The changes overall look fine to me (few spacing nits).
- Prasad
On 2012-01-18 08:47:35, Juhani Connolly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3524/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-18 08:47:35)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Modified configure to check for an exisitng deque, and copy across data if
the size has changed. If the new capacity is smaller than the number of items
remaining in the old one, data is still lost, with a logger warning.
bq.
bq.
bq. This addresses bug FLUME-889.
bq. https://issues.apache.org/jira/browse/FLUME-889
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
1228002
bq.
/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java
1228002
bq.
bq. Diff: https://reviews.apache.org/r/3524/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Created new unit test to check assumptions made along with capacity limits.
bq. New unit test passes
bq. All existing unit tests are fine(except for ExecSource which fails because
of development environment)
bq.
bq.
bq. Thanks,
bq.
bq. Juhani
bq.
bq.
> All events in memory channel are lost on reconfiguration
> --------------------------------------------------------
>
> Key: FLUME-889
> URL: https://issues.apache.org/jira/browse/FLUME-889
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Shu Zhang
> Assignee: Shu Zhang
> Fix For: v1.1.0
>
>
> this line is at the end MemoryChannel.configure(Context)
> queue = new LinkedBlockingDeque<StampedEvent>(capacity);
> memory channel is meant to be dynamically configurable, however every time
> it's reconfigured, all existing events are dropped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
