[
https://issues.apache.org/jira/browse/FLUME-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188877#comment-13188877
]
[email protected] commented on FLUME-889:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3524/
-----------------------------------------------------------
(Updated 2012-01-19 02:03:00.640334)
Review request for Flume.
Changes
-------
Changed to abort capacity change if it would result in dataloss, updating the
test to reflect this.
Also lost all the trailing spaces
Summary
-------
Modified configure to check for an exisitng deque, and copy across data if the
size has changed. If the new capacity is smaller than the number of items
remaining in the old one, data is still lost, with a logger warning.
This addresses bug FLUME-889.
https://issues.apache.org/jira/browse/FLUME-889
Diffs (updated)
-----
/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java
1228002
/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
1228002
Diff: https://reviews.apache.org/r/3524/diff
Testing
-------
Created new unit test to check assumptions made along with capacity limits.
New unit test passes
All existing unit tests are fine(except for ExecSource which fails because of
development environment)
Thanks,
Juhani
> All events in memory channel are lost on reconfiguration
> --------------------------------------------------------
>
> Key: FLUME-889
> URL: https://issues.apache.org/jira/browse/FLUME-889
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Affects Versions: NG alpha 1, NG alpha 2
> Reporter: Shu Zhang
> Assignee: Shu Zhang
> Fix For: v1.1.0
>
>
> this line is at the end MemoryChannel.configure(Context)
> queue = new LinkedBlockingDeque<StampedEvent>(capacity);
> memory channel is meant to be dynamically configurable, however every time
> it's reconfigured, all existing events are dropped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
