[ 
https://issues.apache.org/jira/browse/FLUME-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188976#comment-13188976
 ] 

Juhani Connolly edited comment on FLUME-889 at 1/19/12 7:50 AM:
----------------------------------------------------------------

Here's the patch.

I'm somewhat concerned however about the threading issue mentioned.
Following the code as it is, my understanding was that configurations are going 
to get run through doLoad in AbstractConfigurationProvider, which is thread 
safe. Please correct me if I'm wrong on that, and I'll fix the issue. 

As far as the disallowing of the capacity resizing, that could be a valid 
concern though it would make the simple code more finicky.  I guess it depends 
on how important others feel it would be to others, I can revisit this if 
people feel it's a big deal.
                
      was (Author: juhanic):
    Here's the patch.

I'm somewhat concerned however about the threading issue mentioned.
Following the code as it is, my understanding was that configurations are going 
to get run through doLoad in AbstractConfigurationProvider, which is thread 
safe. Please correct me if I'm wrong on that, and I'll fix the issue
                  
> All events in memory channel are lost on reconfiguration
> --------------------------------------------------------
>
>                 Key: FLUME-889
>                 URL: https://issues.apache.org/jira/browse/FLUME-889
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: NG alpha 1, NG alpha 2
>            Reporter: Shu Zhang
>            Assignee: Shu Zhang
>             Fix For: v1.1.0
>
>         Attachments: FLUME-889-2.patch
>
>
> this line is at the end MemoryChannel.configure(Context)
>     queue = new LinkedBlockingDeque<StampedEvent>(capacity);
> memory channel is meant to be dynamically configurable, however every time 
> it's reconfigured, all existing events are dropped.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to