DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775 [PATCH] padding-left in PDF Renderer ------- Additional Comments From [EMAIL PROTECTED] 2003-11-18 22:50 ------- " During my investigations I also found that the code for recording/restoring BPD and IPD for block-containers was duplicated in the AbstractRenderer. I have removed the duplicated code which makes understanding the code in AbstractRenderer a little easier." Chris, I'm not clear on your "duplication" point--AbstractRenderer is the base class of *every* non-structural renderer--PDF, PCL, PS, TXT, etc., whether the renderer is currently implemented or not. Why are you commenting out generic code in AbstractRenderer based on a particular overridden implementation in a subclass (here, PDFRenderer)? After all, once PDFRenderer overrides a function in AbstractRenderer, it's overridden--where is there a duplication issue? (Also, please clarify *which* methods had the duplication so I can zoom in immediately to what you are talking about--patches--until applied--rarely immediately inform us of that!) Also, commenting out is highly unpleasant here (people forget *why* it's commented out)--if the code is not correct (which I'm not sure of yet, either way), then it should be removed--we always have CVS to bring it back if needed! Thanks again, Glen
