DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775 [PATCH] padding-left in PDF Renderer [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] ------- Additional Comments From [EMAIL PROTECTED] 2003-11-23 21:50 ------- OK, Chris, I'm looking at your changes right now. Some early comments: 1.) Thanks for providing the before & after PDF -- picture is worth a 1,000 words in quickly determining what you're trying to fix. 2.) In the future, just one patch file should be needed per Bugzilla issue (if there's something we disagree with, we can remove that relevant section from the single patch file)--"cvs diff - u > mypatch.txt" from the org/apache/fop directory may be easiest. 3.) Please check our coding standards on http://xml.apache.org/fop/dev/conventions.html In particular: don't use tabs--use four spaces per indent instead Also, follow the Java spacing conventions: http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#682 Instead of: Integer paddingStart = (Integer)block.getTrait(Trait.PADDING_START); IPMarginOffset+=paddingStart.intValue(); This should be done: Integer paddingStart = (Integer) block.getTrait(Trait.PADDING_START); IPMarginOffset += paddingStart.intValue(); I've made the changes to your patches. Thanks, Glen
