DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24775

[PATCH] padding-left in PDF Renderer

[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From [EMAIL PROTECTED]  2003-11-24 19:11 -------
Chris,

1.) I didn't apply the AbstractRenderer patch because the redundancy was not 
evident to me, especially if certain of the three functions you mentioned--
renderBlockViewPort, renderBlocks, renderBlock--end up being overridden.  For 
example, redundancy may have been retained in the other methods to make sure 
everything will still work in case certain functionality was not carried over 
in overriding methods.  To hopefully make the redundancy more apparent to 
others, however, I placed the three methods you mentioned together in the 
source file.  Maybe they will see it--but I'm stumped! 

Again, though, your patch would just have commented out the redundant code 
anyway, which is confusing to others.  They would have no idea the reason:  (1) 
is it broken and you plan on fixing it later?  (2) is it a future enhancement 
waiting for other parts of the code to be ready first?  If the code is indeed 
useless--as you're stating--we'll just remove it the future!

2.) Applied the rest of the patch and it works fine--I even added a bit more to 
handle padding-end.  It also works for nested blocks.  However, background 
properties such as background-color will need fixing, because it is only being 
drawn for the content-rectangle.  According to the spec (section 4.9.4 at 
http://www.w3.org/TR/xsl/slice4.html#rend-border), background color covers the 
whole padding-rectangle, not just the content-rectangle within it. 

Thanks,
Glen

Reply via email to