On 26.10.2005 13:05:26 Manuel Mall wrote: <snip/> > There is no need to expose creation of the Space/Word areas directly to > TextLayoutManager either. TextArea could easily expose an addWord and > an addSpace method instead of the monolithic setText. In the end it > probably boils down to me arguing that the setText logic currently in > TextArea IMO should be in TextLayoutManager (and probably based on its > data structures) because it is an operation closely coupled to layout > and not to areas.
FWIW, I agree with Manuel that the new logic in TextArea shouldn't be there. The area tree should simply be a data structure, nothing more. Splitting functionality in too many places is dangerous. > > Regards > > Luca > > BTW, it would also be really nice to have test cases for this new > feature even if just expanding existing test cases to test for the new > areas created. It would make catching regressions down the track much > easier. +1 to that. The test cases are very important to document what we can do besides checking for regressions. I know this is additional work, especially hard for those who have very little time available to them, but the tests are something that is extremely valuable to improve the quality of our package. Jeremias Maerki
