DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
------- Additional Comments From [EMAIL PROTECTED] 2007-02-12 08:01 -------
(In reply to comment #24)
> (In reply to comment #23)
> > Adrian, thanks for doing this! I've looked at the patch and have a few
> > comments
> > myself:
> > - I'd suggest to rename "strict-configuration" to "validate-configuration"
> > (just
> > a personal preference).
> The configuration will still be validated regardless of the setting of this
> variable. Its just how the error is handled that makes the difference. If
> "strict-configuration" is true then FOP will immediately throw an exception
> processing will terminate. If "strict-configuration" is set to false then FOP
> will log the error and attempt to continue parsing the configuration (if
> > - the name of the variable "strictFO" in FopFactory.configure(Configuration)
> > seems wrong. There's nothing "FO" specific there. Furthermore, some "if
> > (strictFO)" should actually be "if (strictConfig)", right?
> I think you may have been looking at an older patch. The variable
> "strictValidation" is as before and the new variable is called
No, Jeremias is right actually. There are 'if (strictFO)' statements to test if
an exception has to be thrown. That should be 'if
(validateUserConfigStrictly())'. I should have better looked.
Also, in the new code a HyphenationTreeResolver is no longer created and
assigned to the hyphResolver field. That should inevitably lead to
a NullPointerException later, however the hyphenation junit tests pass.
Are you sure of what you're doing?
One other thing: when getting the default-page-settings parameter it's not
necessary to test if pageConfig is null; it will never be. See the javadoc of
> > Adrian, would you please install the CheckStyle plug-in in your IDE? There
> > are a
> > few nits about the Java style in your patch. Checkstyle will help you find
> > them.
Something checkstyle doesn't seem to be catching: we usually don't put spaces
inside brackets: if (test) instead of if ( test ).
> > Get well quickly, Adrian!
> After a weekend in bed am feeling much better today thanks. I had installed
> checksytle but not enabled it! ;-( I will recreate the patch this morning.
Hope you feel better now!
Sorry, I'll ask you to create yet another patch, but that should really be the
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.