I know I'm late on this one but I've only just stumbled over it while
playing with the AFP renderer in the GOCA branch. This change is very
dangerous as it essentially breaks every FOP extension that uses
character content, especially those not developed inside the FOP project.
I'm lucky it doesn't (shouldn't) break Barcode4J but I would strongly
suggest to revert this interface change especially since the method
signature doesn't change while the semantics do.

On 22.06.2008 13:18:03 adelmelle wrote:
> Author: adelmelle
> Date: Sun Jun 22 04:18:03 2008
> New Revision: 670341
> 
> URL: http://svn.apache.org/viewvc?rev=670341&view=rev
> Log:
> Changed FONode.addCharacters() signature to match the characters() event (use 
> 'length' as a parameter instead of 'end')
> 
> Modified:
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FONode.java
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FOText.java
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FOTreeBuilder.java
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FObjMixed.java
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FONode.java
> URL: 
> http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FONode.java?rev=670341&r1=670340&r2=670341&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FONode.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/FONode.java Sun Jun 22 
> 04:18:03 2008
> @@ -274,12 +274,12 @@
>       *
>       * @param data array of characters containing text to be added
>       * @param start starting array element to add
> -     * @param end ending array element to add
> +     * @param length number of elements to add
>       * @param pList currently applicable PropertyList
>       * @param locator location in the XSL-FO source file.
>       * @throws FOPException if there's a problem during processing
>       */
> -    protected void addCharacters(char[] data, int start, int end,
> +    protected void addCharacters(char[] data, int start, int length,
>                                   PropertyList pList,
>                                   Locator locator) throws FOPException {
>          // ignore
<snip/> 



Jeremias Maerki

Reply via email to