https://issues.apache.org/bugzilla/show_bug.cgi?id=45490
--- Comment #5 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-08-04 11:28:09 PST --- (In reply to comment #4) > > I'm no sure if I understand the difference between your suggestion and mine. The end-result is definitely the same, right now, since the workaround for older parsers actually only does something for the file-protocol, while I think the same holds for other types of URLs as well... It's just that 'file:' is probably the most commonly used. That's what I meant by "Even if the code-block does not contain any code yet for other protocols...". Your suggestion would simply bypass the whole block, while mine would only avoid the assignment/modification of the original 'href' variable. If it turns out that in the future, we need a similar workaround for a different protocol, then your change would have to be undone, and mine would probably have to be chosen as an alternative. But in the end, you're right that the result is identical. Not sure what other devs prefer. If nobody gives an explicit opinion in due time (a couple of days), I'll stick my wet finger in the air, and see which one comes out. ;-) Again, thanks for the feedback. If only all bug-reports contained a pointer to the related lines in the source-files, that would make our lives a lot easier... :-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
