Hi Jeremias,
I understand what you are saying, its not ideal that it resides in org.apache.fop. I'm trying to
keep it away separate from the render package as it could be plugged into any engine (painter etc)
which uses the libraries. I guess we can move it to org.apache.fop.util for now, but I don't see
this as a permanent home for the class as its not a utility class its a core rendering/painting
engine room class.
I don't really like "AbstractRenderingState", I'd prefer "AbstractPaintingState" or
"AbstractDrawingState" as the implication that the renderers are necessarily involved is not a good
one. WDYT? I'm happy to take care of committing these changes after we have agreed on things :).
Maybe in the future, especially after you have merged in your Temp_AreaTreeNewDesign branch we could
think about having a 'core' top level package for common engine room classes?
Adrian.
Jeremias Maerki wrote:
Adrian,
would you mind if I renamed AbstractData to AbstractStateData (if it has
to be a top-level class) and moved it together with AbstractState and
StateStack to org.apache.fop.util or org.apache.fop.util.state? I don't
like those classes to be in the top-level FOP package. I'm also not sure
if "AbstractState" is speaking enough after it's moved out of the
"rendering" or "output generation" context. I'm thinking about renaming
that to "AbstractRenderingState".
On 31.10.2008 11:58:46 acumiskey wrote:
Author: acumiskey
Date: Fri Oct 31 02:58:46 2008
New Revision: 709373
URL: http://svn.apache.org/viewvc?rev=709373&view=rev
Log:
Fix for
test/layoutengine/standard-testcases/block-container_absolute-position_fixed.xml.
Added:
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/AbstractData.java
(with props)
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/AbstractState.java
- copied, changed from r708875,
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/AbstractState.java
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/StateStack.java
(with props)
Modified:
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/afp/AFPState.java
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/pdf/PDFState.java
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/AbstractPathOrientedRenderer.java
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/afp/AFPRenderer.java
xmlgraphics/fop/branches/Temp_AFPGOCAResources/src/java/org/apache/fop/render/pdf/PDFRenderer.java
Jeremias Maerki
