https://issues.apache.org/bugzilla/show_bug.cgi?id=46905





--- Comment #9 from Andreas L. Delmelle <adelme...@apache.org>  2009-05-28 
13:04:08 PST ---
(OK, finally back in shape to continue working on this, and some progress in
the meantime...)

Re: the issue with the failing footnote tests

I have found the cause for those failures. There seems to be a logic error in
the subtle change in BreakingAlgorithm.findBreakingPoints(), where penalties
are handled: after the change, a penalty is considered as a legal break if the
penalty value is lower than INFINITE or it is not of class EN_LINE. 
This is wrong. Regardless of the break class, a penalty with that value is
*never* to be considered as a legal break.

Removing that part of the condition makes the failing footnote tests pass. I'm
just a bit uncertain what the precise motivation was to add that one... so I
hope I'm not missing anything here.

--- Comment #10 from Andreas L. Delmelle <adelme...@apache.org>  2009-05-28 
13:04:10 PST ---
(OK, finally back in shape to continue working on this, and some progress in
the meantime...)

Re: the issue with the failing footnote tests

I have found the cause for those failures. There seems to be a logic error in
the subtle change in BreakingAlgorithm.findBreakingPoints(), where penalties
are handled: after the change, a penalty is considered as a legal break if the
penalty value is lower than INFINITE or it is not of class EN_LINE. 
This is wrong. Regardless of the break class, a penalty with that value is
*never* to be considered as a legal break.

Removing that part of the condition makes the failing footnote tests pass. I'm
just a bit uncertain what the precise motivation was to add that one... so I
hope I'm not missing anything here.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to