https://issues.apache.org/bugzilla/show_bug.cgi?id=47805
--- Comment #4 from Jeremias Maerki <jerem...@apache.org> 2009-09-10 00:25:14 PDT --- I'm not seeing any auto-detection in the patch. What do you refer to? The offline PCL production doesn't allow for bi-directional querying of the printer to get its capabilities so there can't be any auto-detection anyway. As Chris noted, not all printers support PCL5C. My Brother HL-1250, for example, prints out garbage with the patch applied. IMO, it's imperative to have a configuration option to enable/disable PCL5C functionality. I see various issues with the patch: - the output is no longer compatible with PCL5 printers. - I got ByteArrayOutOfBoundsExceptions with many of my usual test images. - PJL support is disabled in a hard-coded fashion (Jim, you can disable PJL in configuration, no need to do that in code: http://xmlgraphics.apache.org/fop/trunk/output.html#pcl-configuration) - If I interpreted this correctly from my short test, the color images don't get scaled if the image is not used in its intrinsic size. - PCLGenerator.paintBitmap() converts an image to monochrome even though its later rendered in color which gives away lots of performance. Image conversion is an expensive operation. - an updated patch should be a bit closer to FOP's coding style (no tabs in particular). Also, you should remove your initials spread throughout the code. Due attribution will be given in the status file and the commit messages. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
