On 14.09.2009 22:01:08 pohukai wrote:
> Thank you for your comments.
> 1) Auto-detection wasn't meant to be detecting the actual printer
> capabilities but meant to determine whether grayscaling of images would take
> place.  See line 403 of PCLGenerator.  In our current use of FOP 0.20x, we
> have b/w images but wasn't sure how to force b/w when a color image was
> implemented.

Ah, I see.

> 2) I'm new to FOP and all of it's capabilities and configuration usage.  I
> think a lot of what I really need should be and can be handled there.  I
> wasn't fully aware of this file.
> 3) I didn't change anything with scaling of the images...at least not
> intentionally.  In my testing, with LOTS of jpg, bmp, these render correctly
> and print on the PCL5c perfectly.

I should have phrased that differently. Sorry. The conversion to
black&white currently does the scaling, too, because PCL can't scale
images itself. You probably just missed that you'd need to scale the
color images to get them to the right size.

>  I'd like to implement TIFF compression
> just to get the PCL file size down.

You mean CCITT compression, don't you. FYI, I've started a CCITT Group 4
compressor some time ago, but haven't finished, yet. It's kind of a
little pet project of mine which I only pursue while travelling. Let me
know when you start on that. I can pass you my unfinished code if you
want. Please note that CCITT compression is not just interesting for PCL
output but also for PDF, PostScript and AFP! And besides that Apache
Commons Sanselan could also use that. So it's going to be important to
keep the compressor general and not tied to PCL.

> 4) I wasn't aware of the 'coding' style. I didn't see a style guideline. 
> Can you point me to one?  I was  paranoid of making any changes and only
> placed my initials in there for my reference as I was testing.  Of course,
> these would be removed. 

Our conventions can be found here: 
Please also note the Checkstyle config file in FOP's root directory that
can help you match our conventions. Thanks!!!

> JimG
> Bugzilla from bugzi...@apache.org wrote:
> > 
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=47805
> > 
> > 
> > 
> > --- Comment #4 from Jeremias Maerki <jerem...@apache.org> 2009-09-10
> > 00:25:14 PDT ---
> > I'm not seeing any auto-detection in the patch. What do you refer to? The
> > offline PCL production doesn't allow for bi-directional querying of the
> > printer
> > to get its capabilities so there can't be any auto-detection anyway.
> > 
> > As Chris noted, not all printers support PCL5C. My Brother HL-1250, for
> > example, prints out garbage with the patch applied. IMO, it's imperative
> > to
> > have a configuration option to enable/disable PCL5C functionality.
> > 
> > I see various issues with the patch:
> > - the output is no longer compatible with PCL5 printers.
> > - I got ByteArrayOutOfBoundsExceptions with many of my usual test images.
> > - PJL support is disabled in a hard-coded fashion (Jim, you can disable
> > PJL in
> > configuration, no need to do that in code:
> > http://xmlgraphics.apache.org/fop/trunk/output.html#pcl-configuration)
> > - If I interpreted this correctly from my short test, the color images
> > don't
> > get scaled if the image is not used in its intrinsic size.
> > - PCLGenerator.paintBitmap() converts an image to monochrome even though
> > its
> > later rendered in color which gives away lots of performance. Image
> > conversion
> > is an expensive operation.
> > - an updated patch should be a bit closer to FOP's coding style (no tabs
> > in
> > particular). Also, you should remove your initials spread throughout the
> > code.
> > Due attribution will be given in the status file and the commit messages.
> > 
> > -- 
> > Configure bugmail:
> > https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
> > ------- You are receiving this mail because: -------
> > You are the assignee for the bug.
> > 
> > 
> -- 
> View this message in context: 
> http://www.nabble.com/DO-NOT-REPLY--Bug-47805--New%3A--PATCH--implements-color-pcl-output-tp25353950p25442523.html
> Sent from the FOP - Dev mailing list archive at Nabble.com.

Jeremias Maerki

Reply via email to