https://issues.apache.org/bugzilla/show_bug.cgi?id=48548
--- Comment #4 from Stephan Thesing <[email protected]> 2010-02-22 18:52:41 UTC --- (In reply to comment #3) > I'll try and give more feedback in the next days. Meanwhile, I noticed a few > mistakes in the property handling: > - AFAIU the value of change-bar-class is not required to be unique. The > nesting > level must also be taken into account, which allows to clear any ambiguity in > case the same name is used several times. Also, there is no default value for > this property. yes, and the code in ChangeBarBegin.java only checks, if the same class has already been used in the _actual_ stack of change bars. In ChangeBarEnd.java the class name is removed from the stack of change bars by the pop(), implemented in ChangeBar.java and via the FOUserAgent.java popChangeBar(). That is, the FOUserAgent holds the current stack of nested change bars and there the class must be unique for each one. When the stack is copied to any FObj, a copy of the whole Vector is made and attached. And yes, the class has no default, so it shouldn't have one set in FOPropertyMapping.java > - the default value of change-bar-color is the current value of the color > property, not black. Yes, I was just to lazy to find out, how to get it before I commited the patch:-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
