Thanks!!! On 19.11.2010 11:33:21 Simon Pepping wrote: > I will revert the renaming of public methods. It was not a good idea. > Sorry for the noise. > > Simon > > On Thu, Nov 18, 2010 at 05:03:34PM +0100, Simon Pepping wrote: > > It breaks org.krysalis.barcode4j.fop.BarcodeXMLHandler: getNamespace > > -> getNameSpace (from render.xml.XMLXMLHandler.getNamespace -> > > getNameSpace > > > > On Thu, Nov 18, 2010 at 04:42:44PM +0100, Simon Pepping wrote: > > > render.AbstractGenericSVGHandler.getNamespace -> getNameSpace > > > render.intermediate.extensions.AbstractAction.setID -> setId > > > render.intermediate.extensions.AbstractAction.getID -> getId > > > render.intermediate.extensions.AbstractAction.hasID -> hasId > > > render.intermediate.extensions.AbstractAction.getIDPrefix -> getIdPrefix > > > render.intermediate.extensions.URIAction.getIDPrefix -> getIdPrefix > > > render.XMLHandler.getNamespace -> getNameSpace > > > render.ps.PSImageFormResource.getImageURI -> getImageUri > > > render.xml.XMLXMLHandler.getNamespace -> getNameSpace > > > render.afp.AFPRendererImageInfo.getURI -> getUri > > > fonts.type1.PFMFile.getPostscriptName -> getPostScriptName > > > tools.TestConverter.setBaseDir -> setBasedir > > > tools.anttasks.Fop.setUserconfig -> setUserConfig > > > tools.anttasks.Fop.getUserconfig -> getUserConfig() > > > tools.anttasks.Fop.setFofile -> setFoFile > > > tools.anttasks.Fop.getFofile -> getFoFile > > > tools.anttasks.Fop.setThrowexceptions -> setThrowExceptions > > > tools.anttasks.Fop.getThrowexceptions -> getThrowExceptions > > > apps.PageSequenceResults.getID -> getId > > > fo.FOText.getBaseLineShift -> getBaselineShift > > > cli.CommandLineOptions.getFOFile -> getFoFile > > > cli.CommandLineOptions.getXMLFile -> getXmlFile > > > cli.CommandLineOptions.getXSLFile -> getXslFile > > > > > > On Wed, Nov 17, 2010 at 09:29:06PM +0100, Simon Pepping wrote: > > > > On Wed, Nov 17, 2010 at 07:45:31PM -0000, [email protected] wrote: > > > > > Author: spepping > > > > > Date: Wed Nov 17 19:45:27 2010 > > > > > New Revision: 1036179 > > > > > > > > > > URL: http://svn.apache.org/viewvc?rev=1036179&view=rev > > > > > Log: > > > > > findbugs-reported bug squashing; 959 bugs left (findbugs 1.3.9) > > > > > > > > findbugs reports naming problems in public methods, such as setters > > > > and getters. I resolved those problems. But in doing so, in principle > > > > I am changing the public API. I do not think that every public method > > > > is really in use by other applications. Let me know when I go too far > > > > in those changes, harming applications that depend on fop. > > > > > > > > Simon > > > >
Jeremias Maerki
