https://issues.apache.org/bugzilla/show_bug.cgi?id=52257

Mehdi Houshmand <med1...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27994|0                           |1
        is obsolete|                            |

--- Comment #2 from Mehdi Houshmand <med1...@gmail.com> 2011-11-29 13:22:19 UTC 
---
Created attachment 27998
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27998
font events part deux

How would you suggest the event-broadcaster be injected in? Consider the
following:
- In o.a.f.render.ps.NativeTextHandler, the only way a DefaultEventBroadcaster
is used is if the FontInfo object, given in the constructor is null. The only
time the constructor is called is in the o.a.f.render.ps.AbstractPsTranscoder,
how would you get the event broadcaster when it isn't given?

- in o.a.f.render.intermediate.IFUtil, the DefaultEventBroadcaster is used only
if the FontInfo object is null. Again, how would you inject the broadcaster
when one isn't given? Or should I remove the null check and risk an NPE?

- same applies to o.a.f.svg.PDFDocumentGraphics2D, risk NPE?

- o.a.f.pdf.PDFFactory, this can be piped in a bit further. This has been
amended.

As for the error message, I disagree with your interpretation. The most
important message to convey to the user is that the font isn't supported, we
can't very well create a different message for every situation that a font
isn't supported. The error here isn't in the font, it's that FOP doesn't
currently support the font for whatever reason. As such I've left the error
message as is.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to