Hi Thomas, On 2016-08-04 Thomas Furst wrote: > > This gives me a better idea of HOW the change-bars are applied. As I've > stated from the beginning of this thread, I a new to the FOP source > code, so I will need to start digging into it to get a better > understanding of WHERE these values are determined and used. I can see > where using a static value of 105% would not be ideal.
please include the original text in your replies, sometimes it is hard to decipher what are you refering to. Anyway, we should join our efforts incorporate the current change bars patch into the trunk. The curent code have 2 known issues, both of them rather cosmetic. In my opinion this shouldn't be a blocker. Once it is in main codebase, it will be much more handy to other developers to investigate these issue and propose a fix. To my knowledge, both cases require passing additional info, which is not curently available within the rendering phase: a) actual line height (to make inline change bars touching) b) writing direction (to place change bars to the proper margin) However, the last version of the patch wasn't reviewed for more than one year ... We can just hope it will improve now as there are more people asking this feature ;-) Jan
