Thanks guys so far, I'm sending comments below in text that are also relevant for lzap's comments in previous email.
On středa 12. dubna 2017 16:56:52 CEST Ewoud Kohl van Wijngaarden wrote: > I second that there are cases where "ago" is preferred. For the last > puppet run on the host page it's much easier to know if it was an hour > ago. Then I don't have to try and remember what day and time it is. > However, in a table of all puppet reports then the exact date is the > correct unit. The table of reports with a list of "about 1 month ago" > has been an annoyance I agree that sometime it's more convenient. On reports page it might be interesting only for reports that arrived withing last few hours though. IMHO the consistency is the key here, I'd like to avoid showing 15 minutes ago for times < few hours and full info for the rest. Most of reports on the page (older than few hours) would benefit from the full format. Therefore I think full format with "ago" information as tooltip might be the best compromise? > The same goes for the future value, like the puppet ca expiration date. > Knowing it's in about 4 years is sufficient knowledge. Whether it's in > May or December isn't that relevent at first sight because I know I > don't have to worry about it for some time. Fair enough, in this case we can keep the format we have. Hopefully noone starts to replace the certificate when they see "in about 1 hour" :-) > Regarding the long format I find it much easier to read a table of > 2017-04-12 rows than April. The length of each record should be constant > for easy visual comparison. If there is just one value then a > standardized long format would be preferable. Understood. I think the change of month in 30 rows is more visible so you visually see where one month starts and another begins. Also all April rows will have the info of same length. But I don't insist, we'll see when we have opinions from more. -- Marek > > On Wed, Apr 12, 2017 at 04:18:30PM +0200, Lukas Zapletal wrote: > > I like "ago" format with hover full date value. Thanks for putting > > effort in this! > > > > LZ > > > > On Wed, Apr 12, 2017 at 3:39 PM, Marek Hulán <[email protected]> wrote: > > > Hello, > > > > > > I'd like to suggest one recommended way of displaying date/time > > > information on all pages. We started a discussion in a PR [1] that > > > would change the format for config reports, please take a look there > > > for possible solutions. > > > > > > After a discussion with Roxanne (cc) on another page we agreed on > > > following > > > form to be the best "April 10, 2017 17:08". So no timezone, no seconds, > > > time is localized in current user timezone. Users can quickly see how > > > long it was before so we didn't display the "x y ago" information. We > > > could add it to tooltip if needed. > > > > > > Once nice thing about this format is that Rails provide helper to > > > generate it. One could use something like > > > > > > <%= l(report.last_report_at, :format => :long) %> > > > > > > which prints "April 10, 2017 17:08". The month name and potentially the > > > format is localized based on current user locale. > > > > > > So before I start sending PRs to various places, I'd like to know if we > > > can > > > all agree on one form, ideally the suggested one, and try to use it > > > where it make sense. Please vote either in here or in the linked PR. > > > > > > The list of various places and formats in Foreman and plugins: > > > > > > * Core * > > > reports page - reported at column: "about 1 month ago" > > > dashboard page: "Generated at 12 Apr 12:41" > > > facts - reported at columns: "about 1 year ago" > > > trends page: "Last updated 1 day ago" > > > audit: "about 1 hour ago" with tooltip saying "April 12, 2017 11:25" > > > hosts - last report column: 2 months ago > > > smart proxy - logs - time column: "11. 4. 2017 18:52:31" > > > smart proxy - puppet ca - ca certificate expiry date: "in almost 4 > > > years" > > > > > > * Plugins* > > > discovery - last facts upload: "1 day ago" > > > openscap reports: "about 1 month ago" > > > tasks - task details info: "2 minutes ago" with tooltip "2017-04-12 > > > 12:49:00 UTC" > > > rex - jobs: "about 19 hours ago" > > > rex - logs: "2017-04-11 19:48:09 +0200" > > > katello - last checking, registered at: "2017-04-12 11:42:06 UTC" > > > katello - content host tasks: 4/12/17 1:42 PM > > > > > > Katello would probably need to implement the rails helper (or whatever > > > format we chose) in their UI helpers. Hopefully that's something easy > > > to do. > > > > > > [1] https://github.com/theforeman/foreman/pull/4419#issue-217527751 > > > > > > Thanks for reading and sorry for the long email -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
