On čtvrtek 13. dubna 2017 8:13:11 CEST Timo Goebel wrote: > Am 12.04.17 um 18:21 schrieb Ewoud Kohl van Wijngaarden: > > On Wed, Apr 12, 2017 at 06:02:34PM +0200, Marek Hulán wrote: > >> Thanks guys so far, I'm sending comments below in text that are also > >> relevant for lzap's comments in previous email. > >> > >> On středa 12. dubna 2017 16:56:52 CEST Ewoud Kohl van Wijngaarden wrote: > >>> I second that there are cases where "ago" is preferred. For the last > >>> puppet run on the host page it's much easier to know if it was an hour > >>> ago. Then I don't have to try and remember what day and time it is. > >>> However, in a table of all puppet reports then the exact date is the > >>> correct unit. The table of reports with a list of "about 1 month ago" > >>> has been an annoyance > >> > >> I agree that sometime it's more convenient. On reports page it might be > >> interesting only for reports that arrived withing last few hours though. > >> IMHO the consistency is the key here, I'd like to avoid showing 15 > >> minutes ago for times < few hours and full info for the rest. Most of > >> reports on the page (older than few hours) would benefit from the full > >> format. Therefore I think full format with "ago" information as tooltip > >> might be the best compromise?> > > On the reports (where you see multiple) then I think the "ago" format > > isn't useful because the granularity is too low so it's hard to compare. > > IMHO in a list they should all have the same format. On a host page > > where you see "Last report: 1 hour ago" it does make sense. I hope that > > clarifies it. > > I totally agree. Let's not drop the "time ago in words" format entirely. > It does make sense in a lot of places, especially reports or > certificates or when a host was created. As a user you probably don't > care for the exact time. You just want to know approximately when it > happened. > E.g. when you push new puppet code to your production servers and start > to get calls that something is broken, it's enough to know that there > are puppet reports that indicate a change happend to your servers within > the last hour. As puppet runs happen, when they happen (and the time > when puppet applies changes is hard to predict) an exact timestamp isn't > useful as your cluster slowly starts to degrade over time.
Right, there are places where it makes sense. How about there was always a tooltip so when you hover over "ago" it would display timestamp and vice versa? Also I should have separated two things. At some pages (e.g. reports list) I'd like to change "ago" to timestamp. We can discuss every occurrence individually, when I send a PR, I'll post a link here. Based on above, I won't change e.g. smart proxy ca expiration. Second thing is what the format of timestamp there (and everywhere where we use it) should be. And that's something I'd like to unify everywhere including plugins. Maybe the core should provide a helper that plugins should use to format the date. -- Marek -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
