Not hard feelings from me to remove turbo-links:) -- Ivan
On Thu, Oct 19, 2017 at 7:55 PM, Walden Raines <[email protected]> wrote: > I personally would be okay if we removed turbolinks from foreman entirely. > We want to replace it in the future with a true single page app anyway. But > if others want to put in the effort to maintain it I would support that > effort as well. > > Cheers, > Walden > > On Tue, Oct 17, 2017 at 7:48 PM, Eric D Helms <[email protected]> wrote: >> >> Thanks for the update Michael. I just want to point interested parties to >> the RPM side of the discussions that are on going over in >> https://groups.google.com/forum/#!topic/foreman-dev/xJyxMx1lXy4 >> >> On Tue, Oct 17, 2017 at 4:32 PM, Michael Moll <[email protected]> wrote: >>> >>> Hi, >>> >>> while the original plan was to switch to Rails 5.0 soon and then begin >>> 5.1 work, it's a major downside that RPMs would be broken for a >>> potentially longer period, so I closed >>> https://github.com/theforeman/foreman/pull/4867 and like to draw the >>> attention of interested parties to >>> https://github.com/theforeman/foreman/pull/4836 where all the changes >>> that are queued up lead to a still 100% green Rails 5.0 test run and >>> leave 21 test failures with 5.1. >>> >>> I guess two of iNečas' recently opened PRs will fix some of these. >>> >>> Besides the missing changes to get green tests one major problem is that >>> there's no Rails 5 compatible version of turbolinks-classic, so either >>> Foreman needs to move to turbolinks 5 or a forked turbolinks-classic gem >>> would be needed, if turbolinks should be kept. >>> >>> In the meanwhile Rails 5.1 should be packaged for RPM in some way... :) >>> >>> Regards >>> -- >>> Michael Moll >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "foreman-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >> >> >> >> >> -- >> Eric D. Helms >> Red Hat Engineering >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
