Hi, On Thu, Dec 07, 2017 at 12:52:59PM +0100, Michael Moll wrote: > > > Once there are gem releases out, I'd open PRs to raise the lower version > > boundary of these in core and after these got in, I'd ask > > https://github.com/theforeman/foreman/pull/4867 > > to get merged (BTW, Eric, please see the comment at the bottom). > > > > At that state, core would be using Rails 5.0 only and I'd open one PR > > including the 5.0 only parts of > > https://github.com/theforeman/foreman/pull/4836 > > > > After that one got merged, core would be using Rails 5.0 and be > > incompatible with Rails 4.2.
This did happen now. All PRs should get rebased, so all tests run against Rails 5.0 without supressed deprecation warnings. The next PR regarding Rails 5.1 is https://github.com/theforeman/foreman/pull/5026 which should get green with Rails 5.0 also. Katello tests do currently fail with an error that should be fixed by https://github.com/theforeman/foreman/pull/5036 > > Plugin authors should start updating their plugins to Rails 5.0 > > standards at that point. Ondra's DB migration PRs should get merged now, as these are already compatible with Rails 5.0 Also, all changes that were not compatible with Rails 4.2 should get in now, as Rails 5.1 will remove the deprecated parts. Regards -- Michael Moll -- You received this message because you are subscribed to the Google Groups "foreman-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
