Le 09/03/16 17:00, Chris Pike a écrit :
> Yes, this is what we are currently testing on our servers.
>
> https://github.com/PennState/directory-fortress-core-1/blob/release/src/main/java/org/apache/directory/fortress/core/impl/RoleUtil.java
>
> I still don't understand why #7 needs guarded, but it is guarded by #4. Since 
> the cache is a blocking cache, it returns null on first hit, then blocks 
> until a value is put in the cache. 

True. I totally missed that. All my analysis was based on some cache
that wuld not block...

> By default, the blocking cache will block forever, so I set the timeout to 60 
> seconds as a failsafe. It is possible (however unlikely) that multiple gets 
> could timeout after 60 seconds and result in simultaneous loadGraph calls, so 
> I also made the loadGraph method synchronized.

The syncrhonized method should not be a problem.

Chris, I think it's way better with your approach.

Reply via email to