Yes, I'll commit the changes later today, I already updated those others classes and AdminRoleUtil as well.
I fine with waiting for next release, we are using our own release branch for internal deployments. ----- Original Message ----- From: "Shawn McKinney" <[email protected]> To: [email protected] Sent: Wednesday, March 9, 2016 11:53:57 AM Subject: Re: LDAP Connection Management > On Mar 9, 2016, at 10:44 AM, Emmanuel Lécharny <[email protected]> wrote: > >> >> By default, the blocking cache will block forever, so I set the timeout to >> 60 seconds as a failsafe. It is possible (however unlikely) that multiple >> gets could timeout after 60 seconds and result in simultaneous loadGraph >> calls, so I also made the loadGraph method synchronized. > > The syncrhonized method should not be a problem. > > Chris, I think it's way better with your approach. +1 let’s go with it. There are three functions that need to be changed: PsoUtil RoleUtil UsoUtil and a ticket created to cover the work: https://issues.apache.org/jira/browse/FC-151 Chris since no good deed ever goes unpunished, can you commit the work? Next we can both hammer with jmeter to see if it breaks. One more thing… there is currently a vote in progress for next release, should we delay until this fix goes in? Or wait for the next one, 1.0 GA, which should follow within a few weeks. (my vote) Shawn
