Found another place wehre this might be an issue... OrgUnitP and PolicyP both use read locks in the isValid method and write locks in the add method, but only around getting user and policy sets respectively. Also, it looks like PolicyP calls lock on read lock method multiple times (isValid and getPolicySet).
Since these are both also using a blocking cache, I think the locking is unnecessary. ----- Original Message ----- From: "Chris Pike" <[email protected]> To: [email protected] Sent: Wednesday, March 9, 2016 3:22:15 PM Subject: Re: LDAP Connection Management Changes are committed ----- Original Message ----- From: "Shawn McKinney" <[email protected]> To: [email protected] Sent: Wednesday, March 9, 2016 12:15:13 PM Subject: Re: LDAP Connection Management > On Mar 9, 2016, at 11:08 AM, Chris Pike <[email protected]> wrote: > > Yes, I'll commit the changes later today, I already updated those others > classes and AdminRoleUtil as well. > > I fine with waiting for next release, we are using our own release branch for > internal deployments. Nice work.
