> On Oct 25, 2016, at 12:34 PM, Chris Pike <[email protected]> wrote:
> 
> Started working on the PropertyMgr interface we discussed, but wanted you to 
> take a look before I flushed it out all the way
> 
> 1. PropertyMgrImpl - 
> https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197ManageProperties/src/main/java/org/apache/directory/fortress/core/impl/PropertyMgrImpl.java
>  - New property specific manager 
>  - Does checkAccess checks based on entity type (i.e. Role add/delete/update 
> would require AdminMgrImpl.updateRole)

OK

> On Oct 25, 2016, at 12:34 PM, Chris Pike <[email protected]> wrote:
> 
> 2. PropertyProvider Interface - 
> https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197ManageProperties/src/main/java/org/apache/directory/fortress/core/impl/PropertyProvider.java
>  - Any DAO that supports properties must implement this (see 
> https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197ManageProperties/src/main/java/org/apache/directory/fortress/core/impl/RoleDAO.java)

look good

> On Oct 25, 2016, at 12:34 PM, Chris Pike <[email protected]> wrote:
> 
> 3. PropertyP - 
> https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197ManageProperties/src/main/java/org/apache/directory/fortress/core/impl/PropertyP.java
>  - Determines which DAO to use based on entity

also fine

> On Oct 25, 2016, at 12:34 PM, Chris Pike <[email protected]> wrote:
> 
> 4. New PropertyDAO - 
> https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197ManageProperties/src/main/java/org/apache/directory/fortress/core/impl/PropertyDAO.java
>  - Can manage properties on objects that implement PropertyProvider

what other methods will go here?

Thanks,
Shawn


Reply via email to