I think they should stay in the review managers, since that's where the other find/search methods reside. Ideally, I think you would deprecate most of the other find/search methods and use this pattern instead.
----- Original Message ----- From: "Shawn McKinney" <[email protected]> To: [email protected] Sent: Tuesday, October 18, 2016 12:53:30 PM Subject: Re: Fortress Properties Not bad. Do you think these methods belong in the reviewmgrs or should we open a new interface? Shawn > On Oct 18, 2016, at 11:47 AM, Chris Pike <[email protected]> wrote: > > https://github.com/PennState/directory-fortress-core-1/blob/feature/fc197BuilderPattern/src/test/java/org/apache/directory/fortress/core/impl/DelReviewMgrSearchTest.java > > > ----- Original Message ----- > From: "Shawn McKinney" <[email protected]> > To: [email protected] > Sent: Tuesday, October 18, 2016 12:45:19 PM > Subject: Re: Fortress Properties > >> On Oct 17, 2016, at 8:31 PM, Chris Pike <[email protected]> wrote: >> >> If you are interested, I started playing around with a query builder that >> uses the ldap API FilterBuilder internally >> >> https://github.com/PennState/directory-fortress-core-1/tree/feature/fc197BuilderPattern > > Definitely interested. I see that you have exposed the queryBuilder to the > caller: > > List<AdminRole> findRoles( AdminRoleQueryBuilder queryBuilder ) > + throws SecurityException; > > What does the client code look like that uses this? > > Shawn
