Since this could affect me (a fossil user on windows) I'm commenting: > There should be a FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL
I assume ZLIB is a necessary dependency for compiling fossil while SSL is optional. It makes sense not to ask if we want to build zlib or not at compile time since we cannot build fossil without it. This train of thought applies to sqlite too. If "not-to-build-zlib-all-the-time" is the feature wanted, can this be provided by things like incremental linking/compiling and not an extra compile time argument? > I want to have a dynamically linked fossil.exe OK. But please don't make dynamically linked fossil.exe as the default fossil distribution on windows nor the default compilation process for windows. Few arguments for static linking: http://sta.li/faq http://harmful.cat-v.org/Blog/2007/07/02/1_What_does_dynamic_linking_and_communism_have_in_common/ also, I think a dynamically linked fossil may require the user to install things like https://www.microsoft.com/en-us/download/details.aspx?id=30679 to work. -Gaurav On Wed, Jun 17, 2015 at 8:09 AM, Joe Mistachkin <sql...@mistachkin.com> wrote: > > Jan Danielsson wrote: > > > > Bug: It seems like the build system wrongly assumes that if one is > > building against zlib, one wants to build zlib. There should be a > > FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL. > > > > This is not a bug, per se. Since zlib is in the tree, I figured it was > mostly harmless to build it all the time; however, I have no objection > to your change here. > > > > > Feature: On a few systems I want to have a dynamically linked > > fossil.exe. I'm thinking "FOSSIL_DYNAMIC_LINK=1" (changes default ZLIB > > to zdll.lib, /MT -> /MD, and link against DLL CRT). > > > > Sure, this is a good idea also. Can we please make these changes on a > branch, so that we (you and I and possibly others) can fine-tune them > prior to trunk? > > -- > Joe Mistachkin > > _______________________________________________ > fossil-dev mailing list > fossil-dev@mailinglists.sqlite.org > http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev >
_______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
