On 17/06/15 11:47, Jan Nijtmans wrote:
>> Feature: On a few systems I want to have a dynamically linked
>> fossil.exe. I'm thinking "FOSSIL_DYNAMIC_LINK=1" (changes default ZLIB
>> to zdll.lib, /MT -> /MD, and link against DLL CRT).
>
> Well, I would expect this to be two different options: /MT vs /MD controls
> the C runtime being dynamic or not (which I would expect
> FOSSIL_DYNAMIC_LINK to do), but whether ZLIB is linked
> in dynamically should be a separate choice.
Whether to link ZLIB dynamically or not is already a choice, and that
won't change: ZLIB=zlib.lib vs ZLIB=zdll.lib (using the default zlib
distribution convention).
The difference would be that the default would change if
FOSSIL_DYNAMIC_LINK is set. Rationale: Fossil currently assumes "I
want everything statically linked" (one extreme), I'm looking to give
developers an easy option to get the other extreme ("I want everything
dynamically linked" (sans sqlite3, for now)); that is the intended point
of FOSSIL_DYNAMIC_LINK.
> On windows, I don't see any reason to use a dynamic zlib, it
> only complicates the re-distribution of fossil.exe since
> zlib1.dll then always needs to be re-distributed with it.
Again, and this is entirely my fault -- I should have been clearer,
this is only for internal development systems where one typically has
dynamic zlib and openssl (and sqlite3, in the future) libraries built
for other purposes already -- not for redistributable fossil binaries.
I'm looking to add dynamic linking to libraries an opt-in option, not
make life more complicated for anyone.
Joe and Gaurav have convinced me that it's better to have an option
to *disable* automatic zlib builds, rather than an option to enable it.
That would also mean exactly zero change to the everyday lives of those
who want the regular static builds using Makefile.msc, which is nice.
I'll make the changes on a branch on Friday or so.
--
Kind Regards,
Jan
_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
