On 17/06/15 04:39, Joe Mistachkin wrote: >> Bug: It seems like the build system wrongly assumes that if one is >> building against zlib, one wants to build zlib. There should be a >> FOSSIL_BUILD_ZLIB, just as there is a FOSSIL_BUILD_SSL. > > This is not a bug, per se. Since zlib is in the tree, I figured it was > mostly harmless to build it all the time; however, I have no objection > to your change here.
Oh, okay, thanks -- now I see the rationale. I just looked closer and I see that it's making an assumption about ZLIBDIR and its relation to the zlib sources which aren't always true, and this is why my build fails. I still feel it's conceptually wrong to build a copy of zlib which I won't be using, so I'm going to add the FOSSIL_BUILD_ZLIB option. >> Feature: On a few systems I want to have a dynamically linked >> fossil.exe. I'm thinking "FOSSIL_DYNAMIC_LINK=1" (changes default ZLIB >> to zdll.lib, /MT -> /MD, and link against DLL CRT). > > Sure, this is a good idea also. Can we please make these changes on a > branch, so that we (you and I and possibly others) can fine-tune them > prior to trunk? Of course. For these types of changes, you need not even ask. :) -- Kind Regards, Jan _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
