On Apr 18, 2017, at 1:55 PM, Ross Berteig <r...@cheshireeng.com> wrote: > > On 4/17/2017 8:24 PM, Warren Young wrote: >> I wouldn’t say that regexes and globs are *related* > They are related because they are both notations for describing patterns in > text.
I’m objecting to the genealogical sense of the word “related.” Ford trucks and Chevy trucks can both haul gravel, but they’re not “related” until you trace the ancestry back to farm carts. > Do you prefer "filename" or "file name”? I’m not sure which I write more often. I don’t have a strong preference. For some reason, I feel stronger about “filesystem” vs “file system,” preferring the compound form. I think it’s because I think a filesystem is different from a file system; my doctor’s office has a “file system” behind the front desk, but my computer has a “filesystem”. Anyway, I think this is one of those areas where it’s more important to be consistent than to choose one particular option. > can fossil's build…take advantage of [libicu] I’m trying to get someone else to find that out for me. ;) I can tell you that my fossil builds on macOS and CentOS 7 don’t link to libicu*. A quick scan of the extension’s README.txt file suggests it wouldn’t be very helpful to Fossil if you did cause Fossil to be linked to libicu, presumably by linking it to an external SQLite built against libicu: https://www.sqlite.org/src/artifact?ci=trunk&filename=ext/icu/README.txt It looks like GLOB wouldn’t be affected since Fossil isn’t going to load an ICU collation sequence in before running the GLOB, and most Fossil users aren’t going to make use of Fossil’s REGEXP and LIKE calling features. >> 1. “…match files either on the disk or in the active checkout…” Maybe I’m >> missing something, but that looks like a distinction without a difference to >> me. > Probably my tendency to be pedantic poking out. But ignore-glob is matched to > names on disk and not in the repository How about “in the current checkout directory,” then? That includes files Fossil put there as well as those your build system and such put there. >> 3. “Some examples of character lists:…” I’d merge this list of examples into >> the first bullet point > > I'll fuss with the order here a bit. The first bullet is trying to define a > range in a list, using an example. The next few bullets define a few special > cases that make it possible to name all (printable, at least) characters in > the character list notation. If you don’t like paragraphs within a bullet point, Markdown also supports nested levels of bullets. > I ended up having to email him a photo of my signature. I’m in no hurry, especially since you’ve suggested that I might want to commit my substantive changes myself. I’ve been waiting years to find something I wanted to contribute to Fossil proper; a few more days won’t matter. _______________________________________________ fossil-dev mailing list fossil-dev@mailinglists.sqlite.org http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev
