On 4/14/2017 9:15 PM, Warren Young wrote:
On Apr 14, 2017, at 5:09 PM, Ross Berteig <r...@cheshireeng.com> wrote:

I've checked it in on the glob-docs branch until it has been read by at least 
one more pair of eyes.
How about two pair?  (Because foureyes.  Ahahah.)

Following my usual precept of not letting perfection become the enemy of good enough, I merged the glob-docs branch to trunk yesterday. Thanks to Warren for aggressive proofing and Andy for editorial attention, I think it has surpassed good enough.

My next step is to at least add support for some kind of comment to the files. I'd like to minimize the impact that has on existing globs in the wild, however.

The natural choice would be to consider lines that begin with "#" as comments. This is consistent with the handling of text passed off to an editor for the commit comment by fossil commit. But that might interact with some backup or temporary file names.

Perhaps the right work-around for that is to make lines that begin with one or more "#" followed by a space be comments. That would allow "#*" to still be a file glob, but "# this line is ignored" be a comment. A further restriction would be to only allow whole-line comments. So the condition is first character is #, followed by zero or more # and at least one whitespace.

Might need to completely ignore any UTF-8 BOM at the beginning for sanity as well.

--
Ross Berteig                               r...@cheshireeng.com
Cheshire Engineering Corp.           http://www.CheshireEng.com/
+1 626 303 1602

_______________________________________________
fossil-dev mailing list
fossil-dev@mailinglists.sqlite.org
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/fossil-dev

Reply via email to