Hi Richard,
First of all thanks for your reply. Why we create branches: the idea in our workflow is that stuff in trunk gets put to production (after a continuous integration system runs all the tests on it). One of the steps between development and production is mandatory code review. Obviously, it would be nice if we did said mandatory code review before shipping things off to production, because reverting in production is a relatively expensive operation. (Note: we also have tickets for *features* as a place to store discussion for later references. Features, of course, are generally big enough to warrant >1 commits.) The branch you linked me looks great and almost like something that would work wonders, but I do not understand conceptually why the branch is "open" and not "closed". I think a very easy to implement and useful feature would be to get the entire diff, like you showed me in the second link, as a link on the branch page, for purposes of code review. Especially if there's a way of getting that in a standard format that existing tools understand, so it can be used for producing syntax highlighted and side-by-side diffs (the kind Rietveld or bzr qdiff do). We're used to using code review tools like Rietvield for commenting on diffs. Basically the best feature ever would be Launchpad's merge requests, but I realize that's a huge amount of stuff to implement. cheers lvh _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
