On Sun, Oct 16, 2011 at 3:06 AM, Jan Danielsson <[email protected]>wrote:
> I've done some more updates on the jan-sbsdiff branch. I'd like > people to test it out; view some different diffs and click around a > little. Do things make sense? > Hi, Jan! Despite the slightly awkward layout for the really wide area (it's not your fault - just a side effect of being wide), i really like this. One tiny hint: the background color of the diff area should probably be explicitly set to white. Right now it is transparent, which causes the main content area's border to show through it. (That seems to be skin-dependent - skin "menu on the side" skin doesn't do this). Just in case you haven't tried it yet, i think you could add the wide-scrolling support with: <...your container element... style='overflow:scroll'>... (or adding the equivalent to the theme CSS would probably be a better idea). see what looks good and what doesn't. If you select the built-in skin #4 > (the one with rounded corners and gradients) and then go to the built-in > CSS editor, you'll find some "border-bottom"-properties which are > commented out. i don't see those properties, and AFAIK skins are not synched via the checkin/checkout process (but rather with config push/pull). i think. One thing to pay attention to is that the default skin does not wrap > long lines, while the built-in skin #4 does. Which one do you prefer? > Have you got two version numbers which show this? i can't find any (the vast majority of fossil's code wraps at 80 cols or less). i _think_ i personally prefer the wrapping behaviour, but i _know_ that in different cases i would certainly prefer the other behaviour ;). -- ----- stephan beal http://wanderinghorse.net/home/stephan/
_______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
