On Wed, Nov 2, 2011 at 7:32 PM, Richard Hipp <[email protected]> wrote: > > > On Wed, Nov 2, 2011 at 2:27 PM, Mark Janssen <[email protected]> wrote: >> >> On Wed, Nov 2, 2011 at 3:38 PM, Richard Hipp <[email protected]> wrote: >> > On Wed, Nov 2, 2011 at 10:13 AM, Mark Janssen <[email protected]> >> > wrote: >> >> >> >> Without wanting to open a huge can of worms, IMHO a DVCS should return >> >> artifacts unmodified (e.g. treat everything as a binary file). >> > >> > And Fossil does exactly that. It preserves all files exactly. >> > >> > But in many parts of the world, when you are running windows, you have >> > to >> > convert characters for display on the console. So, the generic routine >> > for >> > displaying text on the console - the routine that you modified - needs >> > to >> > convert to whatever character codes are used by the locale setting. >> > Note >> > that Fossil assumes that standard output is going to a console, not to a >> > file. Conversions are appropriate on standard output. >> > >> >> I agree that console output for windows users for example of commit >> messages should be readable regardless of system encoding. I still >> think conversions are not appropriate for output of fossil artifact >> (you are asking for the artifact verbatim) This is also why I made the >> change in blob_write_to_file and not in fossil_puts. As I windows >> user myself, I expected fossil artifact uuid > file to work. I would >> not be surprised if fossil wrappers use this on windows to display >> specific artifacts. > > But, if you requested the output of a text artifact, you would probably also > expect to be able to read the artifact if it appeared on standard output, I > suspect.
Nope, I would expect the artifact without changes, if I want a readable interpretation I would look for something like "fossil cat" or "fossil artifact-as-readable-in-my-encoding". > > With the patch I put in, you can now have both. On windows, it uses > _isatty() to determine if the content is going to the console or to a file, > and only converts if it is going to the console. > >> >> Mark >> _______________________________________________ >> fossil-users mailing list >> [email protected] >> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users > > > > -- > D. Richard Hipp > [email protected] > > _______________________________________________ > fossil-users mailing list > [email protected] > http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users > > _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
