On Mon, Nov 19, 2012 at 7:39 AM, Stefan Bellon <[email protected]> wrote:

> On Mon, 19 Nov, Richard Hipp wrote:
>
> > The \ character is problematic because Windows cannot contain that
> > character in filenames (except as a separator between directory and
> > file names).  If you were allowed to check this file into Fossil,
> > then the repository could not be checked out on Windows.
>
> But the same is true for
>
>   str"i"ng.h
>
> This file can be added on GNU/Linux to fossil but cannot be checked out
> on Windows.
>
> This seems to me an inconsistency. Either support all allowed filenames
> per OS and skip them on OSes that cannot support them, or go with the
> set of filenames that all OSes can support (at least the mainstream
> ones).
>
> But being able to add str"i"ng.h but not str\i\ng.h seems strange to me.
>

I made the decision to disallow "problematic" characters in Fossil
filenames 6 years ago.  In theory, Fossil could allow these characters in
filenames.  But doing so would enhance the potential for bugs and would
greatly complicate testing of the code.  And I didn't see any value in
doing so.  Simpler is better.

The code that checks for valid filenames is here:

    http://www.fossil-scm.org/fossil/artifact/91e4570f9462?ln=479-513

You are welcomed to modify this in any way you see fit.  If you want to
submit a patch, we will consider adding it.



>
> Greetings,
> Stefan
>
> --
> Stefan Bellon
> _______________________________________________
> fossil-users mailing list
> [email protected]
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>



-- 
D. Richard Hipp
[email protected]
_______________________________________________
fossil-users mailing list
[email protected]
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to