On Tue, 20 Nov, Richard Hipp wrote: > Some uses are less clear. For example, at > http://www.fossil-scm.org/fossil/artifact/33d79f5b0a2?ln=850 we are > converting an entire command-line, which does likely contain some > filenames, but also might contain other text where *?"<>| are > legitimate characters. I think doing the conversion will work OK for > every case where Fossil calls fossil_system(), but we need to be > careful here.
I think you are mixing two separate aspects here. One aspect is the encoding of the input string, the other aspect is the set of acceptable characters for a certain use case (e.g. allowed filenames on Windows). What about reflecting those two aspects as separate functionality, i.e. the encoding conversion should apply to *all* input data regardless of whether read from a file, supplied as command line argument or even read via an environment variable (however what encoding should be assumed is quite a different matter). Then the check regarding allowed character set can be applied on the already converted internal unicode representation. But perhaps I am missing some implementation details I am not aware of. Greetings, Stefan -- Stefan Bellon _______________________________________________ fossil-users mailing list [email protected] http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
