2012/11/25 Richard Hipp <d...@sqlite.org>:
>> 2012/11/25 Jan Nijtmans <jan.nijtm...@gmail.com>:
>> Stefan, I committed your patch to the "bellon-unicode" branch.
>> Feedback welcome! At first sight, looks good to me.
> Stefan, please fill out
> http://www.fossil-scm.org/fossil/doc/trunk/www/copyright-release.html and
> send me a copy via post (maybe also a scan via email) so that I can merge
> the bellon-unicode branch into trunk. Thanks.
Finally, I had a look at the "bellon-unicode" branch. I like the new
"--no-warnings" flag, being less dangerous as the --force flag.
However, that triggered the "consistancy" warning in me
(which has no relation to Steve's work!):
- The "--force" flag is generally used to override fatal errors, the
"--no-warnings" is used to prevent warnings which the user
can answer "y" (or "N") to. But there are currently two
commands which use --force to disable warnings. There
the --no-warnings would be more logical, now that we have it.
Commands affected: "fossil clean" and "fossil scrub"
- Because "fossil clean" and "fossil scrub" used --force before,
I would propose to let the --force flag imply --no-warnings.
Then the user can still use --force, although --no-warnings would
be preferred.
- "fossil commit" had the "--conflict" warning, which is the same
as --force only for one specific type of fatal error: merge conflicts.
I don't think anyone would know about this option (it is added
after 1.24), intuitively I would use --force for that too.
This proposal is in the "bellon-unicode-v2" branch.
Nice work, Steve!
Regards,
Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
