2013/1/21 Stefan Bellon <sbel...@sbellon.de>:
> On Mon, 21 Jan, Jan Nijtmans wrote:
>
>> This patch is now in trunk already, but I'm just wondering if the
>> "unicode-glob"wouldn't better be named "encoding-glob". The
>> actual purpose of this warning is not whether some file
>> contains unicode, the fact that the encoding is known
>> to be not UTF-8 is what's really matters: those files
>> cannot be displayed correctly in the fossil web UI.
>
> Well, then the question is whether not just allow to commit everything
> (regardless of the file content) and guess the encoding for display
> purposes in the web UI.

I'm not trying to discuss whether to allow committing something
or not, that's exactly what the *-glob settings are for. I just
would not like to add a new *-glob setting for every possible
encoding, therefore I propose to rename "unicode-glob"
to "encoding-glob". Then "crnl-glob", "binary-glob" and
"encoding-glob" form a nice triplet of categories which
can be controled separately, without the need to
define any more of them in the future. Opinions?

Fossil 1.24 didn't have "unicode-glob" yet, therefore
now is a good time to re-consider the name before
1.25 is released.

Regards,
       Jan Nijtmans
_______________________________________________
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Reply via email to